fix: Fixes for Deferred Messaging Tests [MTT-5102]#2319
Merged
0xFA11 merged 1 commit intorelease/1.2.0from Nov 21, 2022
Merged
Conversation
MessageHooks had a logic error that, when waiting on messages with `ReceiptType.Received`, would result in it basically ignoring the type of the message it received and just wait for n messages of any type - which resulted in a TimeSyncMessage sometimes inserting itself in between the two messages being waited on and resulting in an early end to the wait before the second message actually arrived.
0xFA11
approved these changes
Nov 21, 2022
NoelStephensUnity
pushed a commit
that referenced
this pull request
Dec 11, 2022
NoelStephensUnity
added a commit
that referenced
this pull request
Dec 11, 2022
…cked from release/1.2.0) (#2338) Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageHooks had a logic error that, when waiting on messages with
ReceiptType.Received, would result in it basically ignoring the type of the message it received and just wait for n messages of any type - which resulted in a TimeSyncMessage sometimes inserting itself in between the two messages being waited on and resulting in an early end to the wait before the second message actually arrived.